Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggle config using capitalised boolean value. #1562

Merged
merged 2 commits into from Jun 8, 2016

Conversation

@EliteTK
Copy link
Contributor

@EliteTK EliteTK commented Jun 8, 2016

It appears that since the introduction of the ability to toggle a config value, the config toggling code sets the specified setting to "True" if it was false and "False" if it was true, although this is not incorrect, it doesn't match the stylistic choice throughout qutebrowser to use lower case "true" and upper case "false" for settings.

This pull request attempts to solve this inconsistency.


This change is Reviewable

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Jun 8, 2016

Thanks! You'll probably need to adjust the test for Using ! and -p in end2end/features/set.feature as that checks for True. Not sure how I never noticed this.

@The-Compiler The-Compiler merged commit a98cd9a into qutebrowser:master Jun 8, 2016
0 of 2 checks passed
@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Jun 8, 2016

Thanks, merged! The failing tests are related to changes I did today, trying to make them work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants