Fix toggle config using capitalised boolean value. #1562

Merged
merged 2 commits into from Jun 8, 2016

Conversation

Projects
None yet
3 participants
@EliteTK
Contributor

EliteTK commented Jun 8, 2016

It appears that since the introduction of the ability to toggle a config value, the config toggling code sets the specified setting to "True" if it was false and "False" if it was true, although this is not incorrect, it doesn't match the stylistic choice throughout qutebrowser to use lower case "true" and upper case "false" for settings.

This pull request attempts to solve this inconsistency.


This change is Reviewable

@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Jun 8, 2016

Collaborator

Thanks! You'll probably need to adjust the test for Using ! and -p in end2end/features/set.feature as that checks for True. Not sure how I never noticed this.

Collaborator

The-Compiler commented Jun 8, 2016

Thanks! You'll probably need to adjust the test for Using ! and -p in end2end/features/set.feature as that checks for True. Not sure how I never noticed this.

@The-Compiler The-Compiler merged commit a98cd9a into qutebrowser:master Jun 8, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@The-Compiler

This comment has been minimized.

Show comment
Hide comment
@The-Compiler

The-Compiler Jun 8, 2016

Collaborator

Thanks, merged! The failing tests are related to changes I did today, trying to make them work now.

Collaborator

The-Compiler commented Jun 8, 2016

Thanks, merged! The failing tests are related to changes I did today, trying to make them work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment