Join GitHub today
Use QLabels to draw hints #1868
This is a complete rewrite of how hints are drawn, which now use native Qt drawing and QLabels instead of injecting elements into the QWebView. This has various benefits:
As an effect of that, how e.g. gradients and the label opacity is configured changes. I've tried to migrate the most common cases, but this will probably require some manual intervention for some users.
Since this is quite a big change with some potential of breakage, I'd appreciate some review. @Kingdread @rcorre @lahwaacz @haasn want to help or try the branch out locally? FWIW, it might be easiest to review this commit by commit.
Current coverage is 81.73% (diff: 86.86%)
@@ master #1868 diff @@ ========================================== Files 120 120 Lines 16789 16738 -51 Methods 0 0 Messages 0 0 Branches 2562 2559 -3 ========================================== - Hits 13711 13680 -31 + Misses 2605 2581 -24 - Partials 473 477 +4