Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upresolve issue #2797 #2808
Conversation
yashar-sb-sb
added some commits
Jul 10, 2017
The-Compiler
requested changes
Jul 10, 2017
Can you please also add a test for this to tests/unit/mainwindow/test_messageview.py? You should be able to just show multiple messages, and then check view._clear_timer.interval().
| multimpy_by = len(self._messages) + 1 | ||
| if multimpy_by > 5: | ||
| multimpy_by = 5 | ||
| interval *= multimpy_by |
This comment has been minimized.
This comment has been minimized.
The-Compiler
Jul 10, 2017
Collaborator
You could simply do interval *= min(5, len(self._messages) + 1)
Why the + 1 though?
This comment has been minimized.
This comment has been minimized.
yashar-sb-sb
Jul 10, 2017
Contributor
Because new message will be added after starting the timer.
That was the way it was done in the original code. I didn't want to change the ordering.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Okay I'll add the tests. |
yashar-sb-sb
added some commits
Jul 10, 2017
The-Compiler
merged commit 7da6908
into
qutebrowser:master
Jul 11, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
|
You're welcome! |
qutebrowser-bot
added
the
status: stale
label
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yashar-sb-sb commentedJul 10, 2017
•
edited by The-Compiler
Show messages longer if there are multiple of them.
This change is