Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value to iszero #18

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Add default value to iszero #18

merged 1 commit into from
Jun 26, 2023

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Jun 6, 2023

Fix #17

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5192908319

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.428%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/qutip_jax/properties.py 4 5 80.0%
Totals Coverage Status
Change from base Build 5192713812: -0.1%
Covered Lines: 718
Relevant Lines: 794
💛 - Coveralls

@Ericgig Ericgig merged commit 6d31dbb into qutip:master Jun 26, 2023
@Ericgig Ericgig deleted the misc.addition branch June 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxiLi BoxiLi BoxiLi approved these changes

@AGaliciaMartinez AGaliciaMartinez Awaiting requested review from AGaliciaMartinez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iszero_jaxarray needs a default value for tol
3 participants
@Ericgig @coveralls @BoxiLi