Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hinton plots with working title #1707

Merged

Conversation

VolodyaCO
Copy link
Contributor

@VolodyaCO VolodyaCO commented Nov 6, 2021

Description
Hinton plots accept a title argument, but the code does not actually set the plot's title. Along with this fix, I also removed unused imports and fixed the other function's titles to avoid verbose such as

if title:
  ax.set_title(title)

where the simple ax.set_title(title) does nothing when title is None.

Related issues or PRs
No related issues or PRs

Changelog
Display a title for hinton and matrix_histogram plots when a title is given.

@coveralls
Copy link

coveralls commented Nov 12, 2021

Coverage Status

Coverage decreased (-0.03%) to 68.295% when pulling ed351d8 on VolodyaCO:hotfix/volodyaco/title-in-visualization into b6b8657 on qutip:master.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if this pull request didn't change the logic in other plotting functions. Could we reduce it to just the hinton fix and then we can merge it?

qutip/visualization.py Outdated Show resolved Hide resolved
qutip/visualization.py Outdated Show resolved Hide resolved
qutip/visualization.py Outdated Show resolved Hide resolved
qutip/visualization.py Outdated Show resolved Hide resolved
qutip/visualization.py Outdated Show resolved Hide resolved
qutip/visualization.py Outdated Show resolved Hide resolved
qutip/visualization.py Outdated Show resolved Hide resolved
VolodyaCO and others added 5 commits December 9, 2021 17:44
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
@hodgestar
Copy link
Contributor

@VolodyaCO I'd like to test these changes out locally, but they look good to me now.

@hodgestar hodgestar modified the milestones: QuTiP 4.6.3, QuTiP 4.7 Feb 4, 2022
@hodgestar hodgestar merged commit a202a3e into qutip:master Mar 2, 2022
@hodgestar
Copy link
Contributor

@VolodyaCO Fix merged. Thank you for contributing it and apologies that such a simple fix took a long time to be merged.

@VolodyaCO VolodyaCO deleted the hotfix/volodyaco/title-in-visualization branch March 3, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants