Hinton plots with working title#1707
Merged
hodgestar merged 12 commits intoqutip:masterfrom Mar 2, 2022
Merged
Conversation
hodgestar
requested changes
Dec 6, 2021
Contributor
hodgestar
left a comment
hodgestar
left a comment
There was a problem hiding this comment.
It would be better if this pull request didn't change the logic in other plotting functions. Could we reduce it to just the hinton fix and then we can merge it?
VolodyaCO
commented
Dec 9, 2021
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
Contributor
|
@VolodyaCO I'd like to test these changes out locally, but they look good to me now. |
hodgestar
approved these changes
Mar 2, 2022
Contributor
|
@VolodyaCO Fix merged. Thank you for contributing it and apologies that such a simple fix took a long time to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hinton plots accept a
titleargument, but the code does not actually set the plot's title. Along with this fix, I also removed unused imports and fixed the other function's titles to avoid verbose such aswhere the simple
ax.set_title(title)does nothing whentitleisNone.Related issues or PRs
No related issues or PRs
Changelog
Display a title for hinton and matrix_histogram plots when a title is given.