Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert sign for plotting with non reversed states #1847

Merged
merged 2 commits into from Apr 8, 2022

Conversation

christian512
Copy link
Contributor

@christian512 christian512 commented Apr 5, 2022

Description
There was a bug for plotting a QC with reversed_states = False, that caused a problem when plotting a measurement with classical storage. This PR fixes this bug.

Related issues or PRs
#1842

Changelog
Fix circuit index used when plotting circuits with non-reversed states.

@coveralls
Copy link

coveralls commented Apr 5, 2022

Coverage Status

Coverage increased (+0.2%) to 69.228% when pulling 6d21f8f on christian512:reverse_state_qc_plotting into 4a59f33 on qutip:master.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Could you also add a test for the generated LaTeX?

This should in addition be submitted as a PR on the qutip-qip repository.

@hodgestar hodgestar added this to the QuTiP 4.7 milestone Apr 6, 2022
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants