Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font color in Preferences doesn't adjust with macOS system wide dark mode #878

Closed
NethumL opened this issue Nov 13, 2021 · 5 comments
Closed

Comments

@NethumL
Copy link

NethumL commented Nov 13, 2021

When setting Dark Mode for the entire OS, VimR activates its dark mode as well. But in Preferences, some of the fonts don't adjust for that. The main ones do (they become white), but the other ones don't.

Steps to reproduce:

  1. Go to macOS System Preferences -> General -> Appearance, and change to Dark mode
  2. Open VimR
  3. Open Preferences

Expected: Font color should become a lighter color, so that it's visible against the dark background
Actual: Font color is still black, so it's difficult to read.

I checked whether it had anything to do with my neovim theme. Disabling it didn't have any effect.

I attached screenshots of how it looks in light mode and dark mode respectively.

Light mode:
light-mode

Dark mode:
dark-mode

VimR version: 0.35.0 (20211105.213803)
neovim version: 0.5.1
macOS version: 11.6 (x86)

@qvacua
Copy link
Owner

qvacua commented Mar 24, 2022

Currently, VimR does not support dark mode. My assumption is that most Neovim users use custom color scheme anyways. Therefore, it can adapt to the color scheme you have selected in Neovim. Turn on Preferences -> Appearance -> Use Neovim's color scheme for main window and tools.

Closing the issue, however, if you want to discuss this issue further, please use #908.

@qvacua qvacua closed this as completed Mar 24, 2022
@qvacua
Copy link
Owner

qvacua commented Mar 24, 2022

The idea proposed in #859 is nice. I'll try to implement it.

@bronzehedwick
Copy link

#859 captures dynamically switching the user Vim theme based on dark/light theme, but does not capture the issue presented here, which is that some text in the Vimr preference pane is still black when in dark mode.
141657642-18262184-3e0f-41e4-9646-f9bc6eaa7771
I think this issue is still valid, and I can replicate on the latest snapshot.

@ELLIOTTCABLE
Copy link

I'm seeing this too — and, yeah, it's unrelated to dark-mode support in Vim-proper.

@j-rahman
Copy link

Why is this issue closed? I just installed a fresh copy of vimr (v. 0.44.0,20230103.174333) and, since I predominantly use Dark Mode, the Preferences window just looks bad and half-baked because of this unresolved very real issue. Since this app purports to be a native Swift app built for macOS, I would expect it to look more than half decent and to support automatic Dark Mode switching off the shelf. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants