New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented xep-0352: Client State Indication #87

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@fbeutel
Contributor

fbeutel commented Oct 23, 2015

No description provided.

@@ -94,6 +94,16 @@ void QXmppStreamFeatures::setTlsMode(QXmppStreamFeatures::Mode mode)
m_tlsMode = mode;
}

This comment has been minimized.

@jlaine

jlaine Sep 4, 2016

Contributor

Please document these two members

/// Returns true if the current client state is "active", false if it is "inactive"
/// See xep-0352.
bool QXmppClient::clientState()

This comment has been minimized.

@jlaine

jlaine Sep 4, 2016

Contributor

I am not sure about the member name, or using a boolean to convey this information. Code like this does not seem very readable:

if (client->clientState()) {
..
}

This comment has been minimized.

@LNJ2

LNJ2 Oct 6, 2018

Contributor

I'd suggest to just call it isActive().

@jlaine

This comment has been minimized.

Contributor

jlaine commented Oct 26, 2018

Superseeded by PR #159

@jlaine jlaine closed this Oct 26, 2018

LNJ2 added a commit to LNJ2/qxmpp that referenced this pull request Oct 28, 2018

Implement XEP-0352: Client State Indication
This commit is based on a pull request by fbeutel (GitHub) (see qxmpp-project#87) and
was rebased and slightly modified by me.

LNJ2 added a commit to LNJ2/qxmpp that referenced this pull request Oct 29, 2018

Implement XEP-0352: Client State Indication
This commit is based on a pull request by fbeutel (GitHub) (see qxmpp-project#87) and
was rebased and slightly modified by me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment