New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoded jar paths #364

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
1 participant
@tresf
Contributor

tresf commented Oct 12, 2018

On Windows, if a path has brackets [, ], the qz-tray.properties path will be encoded into the JAR path as %5d and HTTPS will fail.

This replaces the %20 logic which was originally created for Windows XP and expands it to handle edge-cases. Affects white-label customers as they can choose virtually any product name for branding and installation.

Previous versions of QZ Tray re-used the URL-encoding for publishing the .desktop and .url desktop files, but this logic is long gone, so this should be relatively safe.

@tresf tested with:

  • PASS: Windows: C:\Program Files\[test]\qz-tray.jar
  • PASS: Windows: C:\Program Files\%20\qz-tray.jar
  • PASS: Ubuntu 14.04 (default install)
  • PASS: MacOS: /Applications/[test]/qz-tray.jar

Should be tested with Linux and MacOS desktop installers and regression test against desktop shortcuts just to be safe.

@tresf tresf merged commit 5e8cacc into qzind:2.0 Oct 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tresf tresf deleted the tresf:urlencode branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment