Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS dark mode/retina support #378

Merged
merged 12 commits into from Nov 14, 2018

Conversation

Projects
None yet
1 participant
@tresf
Copy link
Contributor

tresf commented Nov 13, 2018

Some white-label customers have chosen to use a black icon for the system tray but this causes visibility problems on Mojave (10.14) and greater when dark mode is enabled.

This patch attempts will detect a pure black icon and change it to a pure white icon to workaround this problem when "Dark" is returned from the following command:

defaults read -g AppleInterfaceStyle | grep "Dark"

In addition, it uses a screen scale factor getScaleFactor() available as part of the macOS-only sun.awt.CGraphicsDevice class. Reflection is required to avoid compilation errors on on-macOS platforms.

tresf added some commits Nov 13, 2018

ugh

@tresf tresf changed the title macOS dark mode support macOS dark mode/retina support Nov 14, 2018

@tresf tresf merged commit ae9917f into qzind:2.0 Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tresf tresf deleted the tresf:mojave branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.