Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate download to HTTP status page #401

Merged
merged 8 commits into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@tresf
Copy link
Contributor

tresf commented Jan 17, 2019

@bberenz opening a PR so we can have a todo list...

Show resolved Hide resolved src/qz/ws/HttpAboutServlet.java Outdated
Show resolved Hide resolved src/qz/ws/HttpAboutServlet.java Outdated
Show resolved Hide resolved src/qz/ws/HttpAboutServlet.java Outdated
Show resolved Hide resolved src/qz/ws/HttpAboutServlet.java Outdated

@bberenz bberenz force-pushed the http branch from c6c96c5 to 89da0f0 Jan 24, 2019

@bberenz

This comment has been minimized.

Copy link
Member

bberenz commented Jan 24, 2019

Went over the data source in AboutInfo class to see how I could get the data into the ssl block and realized there was a simpler way to do all of this... Data is in ssl block, no aliases are hard coded now.
I can't seem to find sources on the base64 method, which is why I assumed it was using lineSeparator too, that's been correct as well.

I've also rebased off of 2.0, since there seemed to be a conflict with the commits i had sitting in this branch.

Show resolved Hide resolved src/qz/ws/HttpAboutServlet.java Outdated
@tresf

This comment has been minimized.

Copy link
Contributor Author

tresf commented Jan 25, 2019

On my machine, an additional alias qz-tray shows up in the about page. If I click on on it (https://localhost:8181/cert/qz-tray), it says: Could not find certificate with alias "qz-tray" to download..

bberenz added some commits Jan 25, 2019

@tresf

This comment has been minimized.

Copy link
Contributor Author

tresf commented Jan 25, 2019

Looks good. Thanks for patching the cert logic to work with JDK11. Merging.

@tresf tresf merged commit ef3d2aa into 2.0 Jan 25, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tresf tresf deleted the http branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.