Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial JDK11 support #407

Merged
merged 12 commits into from Feb 2, 2019

Conversation

Projects
None yet
1 participant
@tresf
Copy link
Contributor

tresf commented Jan 31, 2019

TODO

  • Bundle jars (done via 7085eda, 1789e29)
  • Bundle native libs (done via 7085eda, 1789e29)
    • Sign native libs on macOS (done via 1789e29)
    • Test/validate against Mojave hardening requirements #372/#388 (artifact passed Feb 1st)
  • Fix illegal exceptions/macOS integration (EAWT/NoSuchMethodException) (done via 179bd91, 3c23ec5)
  • Update Compiling/Dependencies in wiki (edit: javafx download was automated in 6dfc299, a443a31, no updates needed)
  • Add JDK11 target to Travis-CI (Done via 6dfc299)
  • Complete the below test matrix (3 platforms, 2 java versions, 3 use-cases).

Test Matrix

JDK8 Win JDK11 Win JDK8 Lin JDK11 Lin JDK8 Mac JDK11 Mac
Install
CLI
IDE

To Test

  • Checkout this branch
  • Compile/run as usual. Make sure print some HTML to invoke JavaFX engine.

    Test Install

    • Windows: ant nsis && out\qz-tray-2.0.8.exe
    • macOS: ant pkgbuild && sudo installer -pkg out/qz-tray-2.0.8.pkg -target /
    • Linux: ant makeself && sudo bash out/qz-tray-2.0.8.run -- -y

    Test CLI

    • java -jar out/dist/qz-tray.jar

    Test IDE

    • From IntelliJ, configure the JDK and then run src/ws/PrintSocketServer.java

JavaFX Helpers

  • Linux: curl -L http://gluonhq.com/download/javafx-11-0-2-sdk-linux -o fx.zip && unzip fx.zip -d lib/; rm -rf fx.zip
  • macOS: curl -L http://gluonhq.com/download/javafx-11-0-2-sdk-mac -o fx.zip && unzip fx.zip -d lib/; rm -rf fx.zip

Closes #402

@tresf tresf referenced this pull request Jan 31, 2019

Closed

JDK11 Support #402

tresf added some commits Jan 31, 2019

@tresf tresf merged commit ad5c947 into qzind:2.0 Feb 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tresf tresf deleted the tresf:jdk11 branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.