Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdoptOpenJDK detection on Windows #436

Merged
merged 3 commits into from Mar 23, 2019

Conversation

Projects
None yet
2 participants
@tresf
Copy link
Contributor

commented Mar 23, 2019

AdoptOpenJDK does not yet provide a registry key for CurrentVersion per AdoptOpenJDK/openjdk-installer#64.

This PR allows Windows JVM detection to fallback to %PATH% environmental variable.

Note, MacOS and Linux JVM detection work as expected with AdoptOpenJDK.

klabarge and others added some commits Mar 21, 2019

@tresf tresf merged commit d6128f0 into 2.0 Mar 23, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tresf tresf deleted the adoptopenjdk branch Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.