Extend to multiple searches?

[robitalec]

Right now, it seems errorist just searches for the first warning or message.
This came up for me in trying out the package, I was actually more interested in the search results for the second warning..

---

Reproducible example:

library(errorist)

warn2 <- function() {
  warning('warning one')
  warning('warning two')
}

warn2()

[coatless]

@robitalec yes, only searching the first error and warning for the latest function call is accurate.

Having said this, there are two parts here that are drastically different: error and warning.

Error-wise, it isn't possible to have two errors back-to-back within code execution since the code is exited once a single error is detected. We're able to then use the error handler to trigger an appropriate dispatch.

Warning dispatch is another story. errorist was setup to search the first warning returned as multiple identical warnings may occur in a single function call. Though, this might have been slightly too conservative. Potentially, we could trigger a search on distinct warnings by parsing names(list.warning).

Self-note:

errorist/R/handlers.R

Lines 88 to 96 in 8a41cb8

	# Trigger search with added protections since this caller is repeatedly
	# called regardless if a new warning is detected.
	if (!is.na(warning_contents) &&
	(
	is.na(.errorist_env$captured_last_search_warning) ||
	.errorist_env$captured_last_search_warning != warning_contents
	)) {
	search_func(warning_contents)
	}

[robitalec]

Thanks @coatless!
Silly mistake - you never get two errors. Wrote this up a bit quickly clearly, edited above..

Yes - I think we definitely wouldn't want repeated searches from the same warning repeated, but might be useful to search for unique ones, like you say. Thanks!

[coatless]

@robitalec searching multiple warnings should now work. Please try it out in the development version:

remotes::install_github('r-assist/errorist')

[robitalec]

Perfect! That worked @coatless.
Thank you.