Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage #29

Merged
merged 8 commits into from Dec 31, 2019
Merged

Improve code coverage #29

merged 8 commits into from Dec 31, 2019

Conversation

@coatless
Copy link
Collaborator

coatless commented Dec 31, 2019

Following from #28, we lost a bit of code coverage unintentionally... This PR seeks to address that.

Moreover, we disable any parts of code that require interactivity from being tested. (e.g. browser opens)

@coatless coatless merged commit 9b3b928 into master Dec 31, 2019
11 of 12 checks passed
11 of 12 checks passed
windows-latest (release)
Details
windows-latest (release)
Details
windows-latest (devel)
Details
windows-latest (devel)
Details
macOS-latest (release) macOS-latest (release)
Details
macOS-latest (release)
Details
macOS-latest (devel) macOS-latest (devel)
Details
macOS-latest (devel) macOS-latest (devel)
Details
ubuntu-16.04 (3.5)
Details
ubuntu-16.04 (3.5)
Details
ubuntu-16.04 (release)
Details
ubuntu-16.04 (release)
Details
@coatless coatless deleted the more-tests branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.