Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add cells higher than out_cell to depression volume #10

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Don't add cells higher than out_cell to depression volume #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/fsm/fill_spill_merge.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,8 @@ void FillDepressions(
if(dep_labels.count(label(ni))==0 && ni!=out_cell)
continue;

if(topo(nx,ny) > topo(out_cell)) //We may not add any cells higher than the out_cell. Without this check, we would sometimes look at higher cells before checking out_cell for the second time.
continue;
//Ocean cells may be found at the edge of a depression. They might get
//added to this list even if there are other, lower, cells within the
//depression which have not yet been explored. This happens when a flat
Expand Down