Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate dbDriver #21

Closed
hadley opened this issue Oct 12, 2014 · 2 comments
Closed

Deprecate dbDriver #21

hadley opened this issue Oct 12, 2014 · 2 comments
Assignees
Milestone

Comments

@hadley
Copy link
Member

hadley commented Oct 12, 2014

So we can standardise on one way of connecting to a database: dbConnect(RSQLite::SQLite())

@krlmlr krlmlr modified the milestone: 0.5 Jul 6, 2016
@krlmlr
Copy link
Member

krlmlr commented Feb 28, 2017

@hadley: I wonder if there's a good way to infer the constructor just from the package name or environment. Maybe provide a registration entry point in DBI?

@krlmlr krlmlr self-assigned this Feb 28, 2017
@hadley
Copy link
Member Author

hadley commented Feb 28, 2017

I don't think adding another way to get the database driver is a good solution here. IMO it's better to be explicit.

@krlmlr krlmlr closed this as completed in ad1bee8 Mar 1, 2017
krlmlr added a commit that referenced this issue Mar 1, 2017
- Deprecate `dbDriver()` and `dbUnloadDriver()` by documentation (#21).
@ghost ghost removed the in progress label Mar 1, 2017
krlmlr added a commit that referenced this issue Mar 10, 2017
- Interface changes
    - Deprecated `dbDriver()` and `dbUnloadDriver()` by documentation (#21).
    - Renamed arguments to  `sqlInterpolate()` and `sqlParseVariables()` to be more consistent with the rest of the interface, and added `.dots` argument to `sqlParseVariables`. DBI drivers are now expected to implement `sqlParseVariables(conn, sql, ..., .dots)` and `sqlInterpolate(conn, sql, ...)` (#147).

- Interface enhancements
    - Removed `valueClass = "logical"` for those generics where the return value is meaningless, to allow backends to return invisibly (#135).
    - Avoiding using braces in the definitions of generics if possible, so that standard generics can be detected (#146).
    - Added default implementation for `dbReadTable()`.
    - All standard generics are required to have an ellipsis (with test), for future extensibility.    - Improved default implementation of `dbQuoteString()` and `dbQuoteIdentifier()` (#77).
    - Removed `tryCatch()` call in `dbGetQuery()` (#113).

- Documentation improvements
    - Finalized first draft of DBI specification, now in a vignette.
    - Most methods now draw documentation from `DBItest`, only those where the behavior is not finally decided don't do this yet yet.
    - Removed `max.connections` requirement from documentation (#56).
    - Improved `dbBind()` documentation and example (#136).
    - Change `omegahat.org` URL to `omegahat.net`, the particular document still doesn't exist below the new domain.

- Internal
    - Use roxygen2 inheritance to copy DBI specification to this package.
    - Use `tic` package for building documentation.
    - Use markdown in documentation.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants