Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent argument names #235

Closed
2 of 3 tasks
krlmlr opened this issue Mar 26, 2018 · 3 comments
Closed
2 of 3 tasks

Inconsistent argument names #235

krlmlr opened this issue Mar 26, 2018 · 3 comments
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 26, 2018

dbBind(params) vs. dbGetQuery(param).

Better to fix in DBI, extend all to params (or shorten to param) and give a warning if param is used.

Also: conn vs. con .

  • param vs. params
  • conn vs. con
  • n vs. max_rows
@krlmlr
Copy link
Member Author

krlmlr commented Mar 12, 2019

Maybe just permit both names, to avoid confusion?

https://stackoverflow.com/q/55107679/946850

@krlmlr krlmlr added this to the 1.1.0 milestone Aug 23, 2019
@krlmlr
Copy link
Member Author

krlmlr commented Oct 13, 2019

No param arguments found, only in examples. Updating.

@krlmlr
Copy link
Member Author

krlmlr commented Oct 13, 2019

Done here, con -> conn is a larger thing.

@krlmlr krlmlr closed this as completed Oct 13, 2019
krlmlr added a commit that referenced this issue Oct 13, 2019
krlmlr added a commit that referenced this issue Dec 3, 2019
This reverts commit 8a633c7.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant