Remove max.connections from requirements for dbGetInfo(Driver) #56
Assignees
Labels
Comments
|
Actually I think max connections should go away altogether - it's an artefact of the older style of implementing backends. |
|
@hadley +1. |
krlmlr
changed the title
|
I am not sure in general what the purpose of the |
|
At the very least, this allows a general-purpose implementation of show(). |
|
Yes but which properties are used there? |
|
The help for dbGetInfo() has a "wish list". We can start from that, and DBItest would test those, too. See also #54 |
|
I think it would be better to provide an extremely basic show method in DBI, and then assume backend authors will provide richer methods. |
krlmlr
added a commit
to r-dbi/DBItest
that referenced
this issue
Dec 1, 2016
- Not testing for presence of `max.connections` element in `dbGetInfo(Driver)` (r-dbi/DBI#56).
ghost
removed
the
krlmlr
added a commit
to r-dbi/DBItest
that referenced
this issue
Dec 2, 2016
- Not testing for presence of `max.connections` element in `dbGetInfo(Driver)` (r-dbi/DBI#56).
krlmlr
added a commit
that referenced
this issue
Dec 2, 2016
- Remove `valueClass = "logical"` for those generics where the return value is meaningless, to allow backends to return invisibly (#135). - New `dbQuoteIdentifier(DBIConnection, list)` to support quoting multi-component identifiers such as tables in a schema (#71). DBI backends should implement this method for schema support. - Renamed arguments to `sqlInterpolate()` and `sqlParseVariables()`, the former gains a `.dots` argument (#140, #147). until RSQLite 1.1 has been built for OS X - Remove `max.connections` requirement from documentation (#56). - Enable `dbBind()` example (#136). - Use roxygen2 inheritance to copy DBI specification to this package. - Avoid using braces in the definitions of generics if possible, so that standard generics can be detected (#146). - Change `omegahat.org` URL to `omegahat.net`, the particular document still doesn't exist below the new domain. - Use `tic` package for building documentation.
krlmlr
added a commit
to r-dbi/DBItest
that referenced
this issue
Dec 4, 2016
- Use markdown in documentation. - Description of parametrized queries and statements (#88). - New hidden `DBIspec-wip` page for work-in-progress documentation. - Get rid of "Format" and "Usage" sections, and aliases, in the specs. - Not testing for presence of `max.connections` element in `dbGetInfo(Driver)` (r-dbi/DBI#56). - Test multi-row binding for queries and statements (#96). - New `ellipsis` check that verifies that all implemented DBI methods contain `...` in their formals. This excludes `show()` and all methods defined in this or other packages. - Refactored `bind_` tests to use the new `parameter_pattern` tweak (#95). - Rough draft of transaction tests (#36). - New `fetch_zero_rows` test, split from `fetch_premature_close`. - The "compliance" test tests that the backend package exports exactly one subclass of each DBI virtual class. - Document and enhance test for `dbDataType("DBIDriver", "ANY")` (#88). - Minor corrections for "bind" tests. - Isolate stress tests from main test suite (#92). - Refactor test specification in smaller modules, isolated from actual test execution (#81). This breaks the documentation of the tests, which will be substituted by a DBI specification in prose. - Align description of binding with code. - Refactor tests for `dbBind()`, test is run by `BindTester` class, and behavior is specified by members and by instances of the new `BindTesterExtra` class. - The `skip` argument to the `test_()` functions is again evaluated with `perl = TRUE` to support negative lookaheads (#33). - Use `dbSendStatement()` and `dbExecute()` where appropriate. - Avoid empty subsections in Rd documentation to satisfy `R CMD check` (#81).
krlmlr
added a commit
that referenced
this issue
Mar 10, 2017
- Interface changes
- Deprecated `dbDriver()` and `dbUnloadDriver()` by documentation (#21).
- Renamed arguments to `sqlInterpolate()` and `sqlParseVariables()` to be more consistent with the rest of the interface, and added `.dots` argument to `sqlParseVariables`. DBI drivers are now expected to implement `sqlParseVariables(conn, sql, ..., .dots)` and `sqlInterpolate(conn, sql, ...)` (#147).
- Interface enhancements
- Removed `valueClass = "logical"` for those generics where the return value is meaningless, to allow backends to return invisibly (#135).
- Avoiding using braces in the definitions of generics if possible, so that standard generics can be detected (#146).
- Added default implementation for `dbReadTable()`.
- All standard generics are required to have an ellipsis (with test), for future extensibility. - Improved default implementation of `dbQuoteString()` and `dbQuoteIdentifier()` (#77).
- Removed `tryCatch()` call in `dbGetQuery()` (#113).
- Documentation improvements
- Finalized first draft of DBI specification, now in a vignette.
- Most methods now draw documentation from `DBItest`, only those where the behavior is not finally decided don't do this yet yet.
- Removed `max.connections` requirement from documentation (#56).
- Improved `dbBind()` documentation and example (#136).
- Change `omegahat.org` URL to `omegahat.net`, the particular document still doesn't exist below the new domain.
- Internal
- Use roxygen2 inheritance to copy DBI specification to this package.
- Use `tic` package for building documentation.
- Use markdown in documentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Instead of dbGetInfo(Driver) entry.
The text was updated successfully, but these errors were encountered: