Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #239 (update docs on how to cope with stored procedures) #242

Merged
merged 1 commit into from May 1, 2018

Conversation

aryoda
Copy link
Contributor

@aryoda aryoda commented May 1, 2018

I have updated an old vignette file and the roxygen docs of two DBI functions to clarify how stored procedures can be executed via DBI.

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   33.87%   33.87%           
=======================================
  Files          17       17           
  Lines         673      673           
=======================================
  Hits          228      228           
  Misses        445      445
Impacted Files Coverage Δ
R/DBConnection.R 0% <ø> (ø) ⬆️
R/deprecated.R 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be0b47...f3342a0. Read the comment docs.

@@ -274,11 +281,16 @@ setMethod("dbGetQuery", signature("DBIConnection", "character"),
#' Execute an update statement, query number of rows affected, and then close result set
#'
#' Executes a statement and returns the number of rows affected.
#' `dbExecute()` comes with a default implementation
#' [dbExecute()] comes with a default implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to add a link link only the first occurrence of a function on a help page.

@krlmlr krlmlr merged commit 807eed2 into r-dbi:master May 1, 2018
@krlmlr
Copy link
Member

krlmlr commented May 1, 2018

Thanks!

@krlmlr
Copy link
Member

krlmlr commented May 1, 2018

I'll tweak and document myself.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants