feat: New dbBindArrow() to support passing nanoarrow streams for parameter binding#415
Merged
aviator-app[bot] merged 2 commits intomainfrom Dec 17, 2023
Merged
feat: New dbBindArrow() to support passing nanoarrow streams for parameter binding#415aviator-app[bot] merged 2 commits intomainfrom
dbBindArrow() to support passing nanoarrow streams for parameter binding#415aviator-app[bot] merged 2 commits intomainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
krlmlr
force-pushed
the
f-bind-arrow
branch
4 times, most recently
from
aca6c83 to
6342339
Compare
aviator-app
bot
force-pushed
the
f-bind-arrow
branch
3 times, most recently
from
8f61552 to
8498da8
Compare
aviator-app
bot
force-pushed
the
f-bind-arrow
branch
from
da438c5 to
bdf2b6b
Compare
krlmlr
changed the title
dbBindArrow() to support passing nanoarrow streams for parameter binding
Contributor
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Smoke test: stock R |
Contributor
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): pkgdown |
Member
Author
|
This is ready to merge, happy to review after the fact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As simple as it gets:
dbBind()accepts lists or data frames,dbBindArrow()accepts streams. Default wrapper methods for both ways are provided by the DBI package (but can be overridden), the direct path must be implemented by the respective packages.Needs some thought. By extension this also requiresdbSendStatementArrow()anddbExecuteArrow().