Skip to content

docs: update template #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2023
Merged

docs: update template #437

merged 4 commits into from
Dec 20, 2023

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Dec 18, 2023

Fix #428
Fix #438

On https://webaim.org/resources/contrastchecker/ I changed the lightness/darkness to get AAA. It's less colorful as a result, maybe other colors could be found that both are darker/lighter but not sadder. 😅

image

Copy link
Contributor

aviator-app bot commented Dec 18, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented Dec 18, 2023

This pull request can't be queued because it's currently a draft.

@krlmlr
Copy link
Member

krlmlr commented Dec 18, 2023

Thanks, looks good! Please mark ready for review when good, will be auto-merged.

@maelle
Copy link
Contributor Author

maelle commented Dec 18, 2023

I did a bit more work to prevent color changes on hovering (as the color was then not the nicest for contrast). I'm not sure the current choices are the best.

Main links on hovering, wavy underline decoration

image

Nav links on hovering, wavy underline decoration too

image

@krlmlr krlmlr requested a review from hadley December 18, 2023 19:44
@maelle maelle marked this pull request as ready for review December 19, 2023 13:43
@krlmlr krlmlr merged commit 041c4dc into r-dbi:main Dec 20, 2023
@krlmlr
Copy link
Member

krlmlr commented Dec 20, 2023

Thanks! Can you please apply to the other repositories?

@maelle
Copy link
Contributor Author

maelle commented Dec 21, 2023

@krlmlr it seems wiser to create and use a template package holding the configuration file, or do you prefer only configuration edits?

@krlmlr
Copy link
Member

krlmlr commented Dec 21, 2023

A template would be great, thanks!

@maelle
Copy link
Contributor Author

maelle commented Dec 21, 2023

could you please create an empty repo under r-dbi and give me write access? It could be called dbitemplate. Thank you!

@krlmlr
Copy link
Member

krlmlr commented Dec 21, 2023

Happy to accept a repo transfer for a repo you create 😉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrast of some colors BS5 template for pkgdown website
3 participants