Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overwrite_table_missing assuming factor conversion #141

Closed
hannes opened this issue Jul 7, 2017 · 0 comments
Closed

overwrite_table_missing assuming factor conversion #141

hannes opened this issue Jul 7, 2017 · 0 comments

Comments

@hannes
Copy link

hannes commented Jul 7, 2017

The overwrite_table_missing test case (and others) writes the iris dataset, where the Species column is a factor to the database, then reads it back and checks for equality. However, it is not clear how dbWriteTable should preserve factors, for which no equivalent SQL type exists. Suggest to make this less brittle by converting Species column to a string beforehand.
@krlmlr krlmlr closed this as completed in 862bdd5 Jul 8, 2017
krlmlr added a commit that referenced this issue Jul 23, 2017
@krlmlr
Merge tag 'v1.5-11'
cc7a768 
- Added test for `dbIsValid()` on stale connections.
- `test_all()` and `test_some()` return `NULL` invisibly.
- Convert factor to character for iris data (#141).
- Don't specify `Inf` and `NaN` for lack of consistent support (#142).
- Clear result in `spec_meta_get_info_result` (#143).
- Use named argument for `n` in `dbGetQuery()` call.
- Minor fixes.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannes