Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R-devel breaking cannot_forget_disconnect #150

Closed
hannes opened this issue Sep 14, 2017 · 1 comment
Closed

R-devel breaking cannot_forget_disconnect #150

hannes opened this issue Sep 14, 2017 · 1 comment

Comments

@hannes
Copy link

hannes commented Sep 14, 2017

I am getting

Error: Test failed: 'DBItest: Connection: cannot_forget_disconnect'
* gc() showed 0 warnings
In addition: Warning message:
In .Internal(gc(verbose, reset)) :
  Connection is garbage-collected, use dbDisconnect() to avoid this.

A bit counter-intuitive, the warning is clearly happening, but the test is not seeing it?!
@krlmlr
Copy link
Member

krlmlr commented Sep 17, 2017

Thanks. This now also breaks RSQLite. Maybe we need to call gc() twice to really see the warning?

@krlmlr krlmlr closed this as completed in 4a40677 Sep 23, 2017
krlmlr added a commit that referenced this issue Sep 24, 2017
@krlmlr
Merge tag 'v1.5-21'
9e72774 
- Full interface compliance doesn't require a method fo `dbGetInfo(DBIDriver)` for now.
- Remove `"cannot_forget_disconnect"` test that fails on R-devel (#150).
krlmlr added a commit that referenced this issue Dec 10, 2017
@krlmlr
warning on disconnect, closes #150
5c946fe 
- Remove `"cannot_forget_disconnect"` test that fails on R-devel (#150).
krlmlr added a commit that referenced this issue Dec 18, 2017
@krlmlr
Merge branch 'h-#150-gc'
e886c57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannes @krlmlr