Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test vectorization #18

Closed
krlmlr opened this issue Nov 10, 2015 · 2 comments
Closed

Test vectorization #18

krlmlr opened this issue Nov 10, 2015 · 2 comments
Milestone
1.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 10, 2015

dbQuoteIdentifier() should not be: r-dbi/DBI#24.

dbQuoteString() should.
@krlmlr krlmlr added this to the 0.1 milestone Nov 10, 2015
@krlmlr krlmlr changed the title Test if dbQuote...() functions are vectorized Test if dbQuote...() and dbDataType() functions are vectorized Nov 10, 2015
@krlmlr krlmlr changed the title Test if dbQuote...() and dbDataType() functions are vectorized Test if dbQuote...() and dbDataType() functions are not vectorized Nov 11, 2015
@krlmlr
Copy link
Member Author

krlmlr commented Nov 13, 2015

There's no reason for forbidding vectorization of dbQuoteString(), only crucial for dbQuoteIdentifier(). No need to check for dbDataType(), as this function expects typed values.

@krlmlr krlmlr changed the title Test if dbQuote...() and dbDataType() functions are not vectorized Test vectorization Nov 13, 2015
@krlmlr krlmlr closed this as completed in ab3253b Nov 13, 2015
krlmlr pushed a commit that referenced this issue Nov 14, 2015
Merge tag 'v0.2-2' into develop
d338b14 
- Refactor `data_` tests to use a worker function `test_select()`
- Test tables with `NA` values above and below the non-`NA` value in `data_` tests
- Test return values and error conditions for `dbBind()` and `dbClearResult()` (#31)
- Test vectorization of `dbQuoteString()` and `dbQuoteIdentifier()` (#18)
- Test that dates have `integer` as underlying data type (#9)
- Roundtrip tests sort output table to be sure (#32)
- Avoid using `data.frame()` for date and time columns (#10)
- Use `expect_identical()` instead of `expect_equal()` in many places (#13)
krlmlr pushed a commit that referenced this issue Nov 15, 2015
Merge tag 'v0.3' into develop
2d6fa83 
- Feature-complete, ready for review
- Tests from the proposal
    - Add missing methods to compliance check
    - Add simple read-only test (#27)
    - Add stress tests for repeated load/unload (with and without connecting) in new R session (#2),
    - Migrate all tests from existing backends (#28)
    - Refactor `data_` tests to use a worker function `test_select()`
    - Test tables with `NA` values above and below the non-`NA` value in `data_` tests
    - Test return values and error conditions for `dbBind()` and `dbClearResult()` (#31)
    - Test vectorization of `dbQuoteString()` and `dbQuoteIdentifier()` (#18)
    - Test that dates have `integer` as underlying data type (#9)
    - Roundtrip tests sort output table to be sure (#32)
    - Test `NA` to `NULL` conversion in `dbQuoteString()`, and false friends (#23)
    - Enhance test for `dbQuoteIdentifier()` (#30)
- Style
    - Avoid using `data.frame()` for date and time columns (#10)
    - Use `expect_identical()` instead of `expect_equal()` in many places (#13)
    - Catch all errors in `on.exit()` handlers via `expect_error()` (#20).
    - Combine "meta" tests into new `test_meta()` (#37)
- Documentation
    - New "test" vignette (#16)
    - Add package documentation (#38)
- Same as 0.2-5
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@krlmlr