Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of with_connection({...}) and other with_...({...}) functions #184

Closed
krlmlr opened this issue Aug 26, 2020 · 1 comment · Fixed by #253
Closed

Eliminate use of with_connection({...}) and other with_...({...}) functions #184

krlmlr opened this issue Aug 26, 2020 · 1 comment · Fixed by #253
Labels
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Aug 26, 2020

for better error stack traces. Replace by local_...() variants if possible.

Idea: testing functions gain a con argument if they require a connection, caller checks signature and passes con argument.

A few tests test what happens when/after connection is closed. Rewrite using on.exit().

@krlmlr krlmlr added the feature label Aug 26, 2020
@krlmlr krlmlr changed the title Eliminate use of with_connection({...}) Eliminate use of with_connection({...}) and other with_...({...}) functions Oct 21, 2020
@krlmlr krlmlr added this to the 1.7.2 milestone Dec 6, 2021
krlmlr added a commit that referenced this issue Dec 16, 2021
- Replace internal `with_result()` with `local_result()` for better error traces (#184, #250).
This was referenced Dec 16, 2021
krlmlr added a commit that referenced this issue Dec 16, 2021
- `local_remove_test_tables()` (#184, #251).
krlmlr added a commit that referenced this issue Dec 17, 2021
- Inline `with_rollback_on_error()` (#184, #253).
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant