Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of expect_is() to support compatibility with testthat 3e #231

Closed
michaelquinn32 opened this issue Jun 24, 2021 · 4 comments · Fixed by #232
Closed

Remove uses of expect_is() to support compatibility with testthat 3e #231

michaelquinn32 opened this issue Jun 24, 2021 · 4 comments · Fixed by #232

Comments

@michaelquinn32
Copy link
Contributor

I'm updating R packages to use testthat third edition, and I've noticed that DBItest is still using expect_is() in a few locations. Would you like a PR to clean this up?
@krlmlr
Copy link
Member

krlmlr commented Jun 24, 2021

This would be awesome, thanks! Is this still an issue with the current development version?

@michaelquinn32
Copy link
Contributor Author

It seem so:
https://github.com/r-dbi/DBItest/search?q=expect_is

There are also calls to expect_that() that could be fixed as well:
https://github.com/r-dbi/DBItest/search?q=expect_that

@michaelquinn32
Copy link
Contributor Author

Maybe I misunderstood what dev version means, but it's at least there in the 1.7.1 branch. See:
https://github.com/r-dbi/DBItest/blob/cran-1.7.1/R/spec-meta-get-statement.R

@michaelquinn32 michaelquinn32 mentioned this issue Jun 24, 2021
Merged
krlmlr added a commit that referenced this issue Sep 5, 2021
@krlmlr
Merge pull request #232 from michaelquinn32/main
30fd043 
- Improve testthat 3e compatibility: remove `testthat::expect_is()` and `testthat::expect_that()` from tests (#231, @michaelquinn32).
MichaelChirico added a commit to MichaelChirico/DBItest that referenced this issue Feb 14, 2022
@MichaelChirico
Complete removal of expect_is()
31e86cd 
Follow up to r-dbi#231. Not sure how these survived :)
@MichaelChirico MichaelChirico mentioned this issue Feb 14, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove expect_is and expect_that from tests michaelquinn32/DBItest
2 participants
@krlmlr @michaelquinn32