Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dbListFields() #26

Closed
2 tasks
krlmlr opened this issue Nov 11, 2015 · 3 comments
Closed
2 tasks

Test dbListFields() #26

krlmlr opened this issue Nov 11, 2015 · 3 comments
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 11, 2015

  • Test
  • DBI vignette entry

Missing in proposal.

@krlmlr krlmlr changed the title Test dbListFields Test dbListFields()/dbColumnInfo() Nov 12, 2015
@krlmlr
Copy link
Member Author

krlmlr commented Nov 13, 2015

dbColumnInfo() is tested.

@krlmlr krlmlr closed this as completed Nov 13, 2015
@krlmlr krlmlr added this to the bluesky milestone Nov 14, 2015
@krlmlr
Copy link
Member Author

krlmlr commented Nov 14, 2015

dbListFields() is different from dbColumnInfo().

@krlmlr krlmlr reopened this Nov 14, 2015
@krlmlr krlmlr changed the title Test dbListFields()/dbColumnInfo() Test dbListFields() Nov 14, 2015
@krlmlr krlmlr modified the milestones: bluesky, 1.1 Nov 15, 2015
@krlmlr
Copy link
Member Author

krlmlr commented Jan 5, 2016

Also needs to test return value after removing fields: r-dbi/RPostgres#76.

@krlmlr krlmlr closed this as completed in 76f1776 Feb 9, 2016
krlmlr pushed a commit that referenced this issue Feb 10, 2016
- The `run_test()` function doesn't require a development version of `testthat` anymore. (Regression introduced in 1.0-5.)
- Avoid using weird column names in `roundtrip_quotes` test if the `strict_identifier` tweak is enabled.
- Add test for `dbGetInfo(Result)` (r-dbi/DBI#55).
- Add test for `dbListFields()` (#26).
- Some SQL dialects (e.g., BigQuery) require parentheses for the functions `current_date`, `current_time` and `current_timestamp`. This can be specified with the new tweak `current_needs_parens`.
- New tweak `omit_blob_tests` for DBMS that don't have a BLOB data type.
krlmlr pushed a commit that referenced this issue Feb 12, 2016
- New feature: tweaks
    - New argument `tweaks` to `make_context()` (#49).
    - New `tweaks()`, essentially constructs a named list of tweaks but with predefined and documented argument names.
    - `constructor_name`, respected by the `constructor.*` tests.
    - `strict_identifier`, if `TRUE` all identifier must be syntactic names even if quoted. The quoting test is now split, and a part is ignored conditional to this tweak. The `roundtrip_quotes` tests also respects this tweak.
    - `omit_blob_tests` for DBMS that don't have a BLOB data type.
    - `current_needs_parens` -- some SQL dialects (e.g., BigQuery) require parentheses for the functions `current_date`, `current_time` and `current_timestamp`.
    - `union`, for specifying a nonstandard way of combining queries. All union queries now name each column in each subquery (required for `bigrquery`).

- New tests
    - `dbGetInfo(Result)` (r-dbi/DBI#55).
    - `dbListFields()` (#26).
    - New "package_name" test in `test_getting_started()`.
- Improved tests
    - Stress test now installs package in temporary library (before loading `DBI`) using `R CMD INSTALL` before loading DBI (r-dbi/RSQLite#128, #48).
    - Row count is now tested for equality but not identity, so that backends can return a numeric value > 2^31 at their discretion.
    - Call `dbRemoveTable()` instead of issuing `DROP` requests, the latter might be unsupported.
    - Use subqueries in queries that use `WHERE`.
    - Test that `dbClearResult()` on a closed result set raises a warning.
    - Expect a warning instead of an error for double disconnect (#50).
    - Move connection test that requires `dbFetch()` to `test_result()`.
    - Split "can_connect_and_disconnect" test.
    - Expect `DBI` to be in `Imports`, not in `Depends`.
- Removed tests
    - Remove test for `dbGetException()` (r-dbi/DBI#51).
- Bug fixes
    - Fix broken tests for quoting.
- Self-testing
    - Test `RPostgres`, `RMySQL`, `RSQLite` and `RKazam` as part of the Travis-CI tests (#52).
    - Travis CI now installs rstats-db/DBI, updated namespace imports (`dbiCheckCompliance()`, `dbListResults()`).

    - Use fork of `testthat`.
- Utilities
    - Return test results as named array of logical. Requires r-lib/testthat#360, gracefully degrades with the CRAN version.
- Internal
    - Refactored the `get_info_()` tests to use a vector of names.
    - Use versioned dependency for DBI
    - Use unqualified calls to `dbBind()` again
- Same as 1.0-8.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant