DBItest causes warning on testthat 3rd edition (context() is deprecated)

[MichaelChirico]

testthat::context() is deprecated in the 3rd edition, but it's always called here:

DBItest/R/run.R

Line 15 in e9286cb

context(test_context)

Should that simply be escaped?

if (testthat::edition_get() < 3) context(test_context)

Or given the current version requirement on testthat, more robustly:

if (packageVersion("testthat") < "3.0.0" || testthat::edition_get() < 3) context(test_context)

Happy to file a PR for whatever's the desired behavior.

[krlmlr]

Thanks. I'm aware of that, and I'm not sure how to deal with it yet. Perhaps we need to make the descriptions in the generated calls to test_that() more verbose, so that they contain what previously was part of the context?

[MichaelChirico]

isn't that done already?

DBItest/R/run.R

Line 43 in e9286cb

test_that(paste0(test_context, ": ", test_name), {