Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests from existing backends #28

Closed
4 tasks done
krlmlr opened this issue Nov 11, 2015 · 3 comments
Closed
4 tasks done

Migrate tests from existing backends #28

krlmlr opened this issue Nov 11, 2015 · 3 comments
Milestone

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 11, 2015

  • RMySQL
  • RPostgres
  • RSQLite
  • Open pull requests

Ensure that all lines covered by master are covered after removing the tests.

@krlmlr krlmlr added this to the 1.0 milestone Nov 11, 2015
@krlmlr
Copy link
Member Author

krlmlr commented Nov 14, 2015

Migration of tests from pull requests postponed.

@krlmlr
Copy link
Member Author

krlmlr commented Nov 14, 2015

Previously covered lines in RSQLite:

8d8
< R/datasetsDb.R:17
--
35d69
< R/query.R:64

And some more lines in sqlite.c, which is already very well tested.

For the other backends, all previously covered lines are still covered.

@krlmlr krlmlr closed this as completed in 37f4646 Nov 14, 2015
krlmlr pushed a commit that referenced this issue Nov 14, 2015
- Package is now feature-complete
- Migrate all tests from existing backends (#28)
- Implement simple read-only test (#27)
- Stress tests for repeated load/unload (with and without connecting) in new R session (#2)
krlmlr pushed a commit that referenced this issue Nov 15, 2015
- Feature-complete, ready for review
- Tests from the proposal
    - Add missing methods to compliance check
    - Add simple read-only test (#27)
    - Add stress tests for repeated load/unload (with and without connecting) in new R session (#2),
    - Migrate all tests from existing backends (#28)
    - Refactor `data_` tests to use a worker function `test_select()`
    - Test tables with `NA` values above and below the non-`NA` value in `data_` tests
    - Test return values and error conditions for `dbBind()` and `dbClearResult()` (#31)
    - Test vectorization of `dbQuoteString()` and `dbQuoteIdentifier()` (#18)
    - Test that dates have `integer` as underlying data type (#9)
    - Roundtrip tests sort output table to be sure (#32)
    - Test `NA` to `NULL` conversion in `dbQuoteString()`, and false friends (#23)
    - Enhance test for `dbQuoteIdentifier()` (#30)
- Style
    - Avoid using `data.frame()` for date and time columns (#10)
    - Use `expect_identical()` instead of `expect_equal()` in many places (#13)
    - Catch all errors in `on.exit()` handlers via `expect_error()` (#20).
    - Combine "meta" tests into new `test_meta()` (#37)
- Documentation
    - New "test" vignette (#16)
    - Add package documentation (#38)
- Same as 0.2-5
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant