Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for repeated dbBind() #51

Closed
krlmlr opened this issue Jan 13, 2016 · 0 comments
Closed

Add test for repeated dbBind() #51

krlmlr opened this issue Jan 13, 2016 · 0 comments
Milestone
3

Comments

@krlmlr
Copy link
Member

krlmlr commented Jan 13, 2016 •
edited
Loading 

res <- dbSendQuery(con, sql)
dbBind(res, list(...))
data <- dbFetch(res)
# dbClearResult(res) # no clearing of result here
dbBind(res, list(...))
data <- dbFetch(res)
dbClearResult(res)
@krlmlr krlmlr added this to the 1.2 milestone Jan 13, 2016
@krlmlr krlmlr closed this as completed in 457d52f Jun 8, 2016
krlmlr pushed a commit that referenced this issue Jun 8, 2016
Merge tag 'v1.2-1'
c84f469 
- Add test for repeated `dbBind()` + `dbFetch()` on the same result set (#51).
- Indicate that some tests are optional (#15).
- Work around regression in R 3.3.0 (fix scheduled for R 3.3.1) which affected stress tests.
krlmlr pushed a commit that referenced this issue Jul 7, 2016
Merge tag 'v1.3'
c960096 
Bug fixes
---------

- Fix `read_table` test when the backend actually returns the data in a different order.

New tests
---------

- Test `dbDataType()` on connections (#69, #75, @imanuelcostigan).
- Check returned strings for UTF-8 encoding (#72).
- Repeated `dbBind()` + `dbFetch()` on the same result set (#51).

Features
--------

- `tweaks()` gains an `...` as first argument to support future/deprecated tweaks (with a warning), and also to avoid unnamed arguments (#83).
- `testthat` now shows a more accurate location for the source of errors, failures, and skips (#78).
- Aggregate skipped tests, only one `skip()` call per test function.
- Indicate that some tests are optional in documentation (#15).

Internal
--------

- New `constructor_relax_args` tweak, currently not queried.
- The `ctx` argument is now explicit in the test functions.
- Change underscores to dashes in file names.
- Remove `testthat` compatibility hack.
- New `all_have_utf8_or_ascii_encoding()` which vectorizes `has_utf8_or_ascii_encoding()`.
- Test on AppVeyor (#73).
- Work around regression in R 3.3.0 (fix scheduled for R 3.3.1) which affected stress tests.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3
Development

No branches or pull requests
1 participant
@krlmlr