Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly check Encoding() for returned character columns #72

Closed
krlmlr opened this issue May 24, 2016 · 1 comment
Closed

Explicitly check Encoding() for returned character columns #72

krlmlr opened this issue May 24, 2016 · 1 comment
Assignees
@krlmlr

Comments

@krlmlr
Copy link
Member

krlmlr commented May 24, 2016

Should always be "UTF-8".

r-dbi/RSQLite#88
@krlmlr krlmlr added the ready label May 25, 2016
@krlmlr krlmlr self-assigned this May 25, 2016
@krlmlr krlmlr added in progress and removed ready labels May 25, 2016
@krlmlr krlmlr mentioned this issue Jun 16, 2016
Closed
krlmlr pushed a commit that referenced this issue Jun 20, 2016
Merge branch 'master' into feature/#72-encoding
709f730
krlmlr pushed a commit that referenced this issue Jun 20, 2016
Merge branch 'feature/#72-encoding'
9db3a4f 
- Check returned strings for UTF-8 encoding (#72).
@krlmlr
Copy link
Member Author

krlmlr commented Jun 20, 2016

Consider using utf8 package for better checks.

krlmlr pushed a commit that referenced this issue Jun 20, 2016
Merge tag 'v1.2-2'
dd45072 
- Test on AppVeyor (#73).
- Check returned strings for UTF-8 encoding (#72).
- Test `dbDataType()` on connections (#69, #75, @imanuelcostigan).
@krlmlr krlmlr closed this as completed Jun 21, 2016
@krlmlr krlmlr mentioned this issue Jun 21, 2016
Closed
krlmlr pushed a commit that referenced this issue Jul 7, 2016
Merge tag 'v1.3'
c960096 
Bug fixes
---------

- Fix `read_table` test when the backend actually returns the data in a different order.

New tests
---------

- Test `dbDataType()` on connections (#69, #75, @imanuelcostigan).
- Check returned strings for UTF-8 encoding (#72).
- Repeated `dbBind()` + `dbFetch()` on the same result set (#51).

Features
--------

- `tweaks()` gains an `...` as first argument to support future/deprecated tweaks (with a warning), and also to avoid unnamed arguments (#83).
- `testthat` now shows a more accurate location for the source of errors, failures, and skips (#78).
- Aggregate skipped tests, only one `skip()` call per test function.
- Indicate that some tests are optional in documentation (#15).

Internal
--------

- New `constructor_relax_args` tweak, currently not queried.
- The `ctx` argument is now explicit in the test functions.
- Change underscores to dashes in file names.
- Remove `testthat` compatibility hack.
- New `all_have_utf8_or_ascii_encoding()` which vectorizes `has_utf8_or_ascii_encoding()`.
- Test on AppVeyor (#73).
- Work around regression in R 3.3.0 (fix scheduled for R 3.3.1) which affected stress tests.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krlmlr krlmlr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krlmlr