Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different SQL dialects in test cases #76

Closed
imanuelcostigan opened this issue Jun 4, 2016 · 5 comments
Closed

Allow for different SQL dialects in test cases #76

imanuelcostigan opened this issue Jun 4, 2016 · 5 comments

Comments

@imanuelcostigan
Copy link
Contributor

A quick note for the time being, which I will hopefully have time to expand a bit later.

The test_result() suite runs a number of data type tests which I think rely on data type names which may not be coextensive across DBMS. For example, the data_logical() tries to cast the integer 1 to a boolean value. However, SQL Server for example, does not have a BOOLEAN type; rather it has a BIT type.

Is there some way that we can map type names across different DBMS to make these tests more backend agnostic?

@imanuelcostigan
Copy link
Contributor Author

Consistently calling dbDataType on the expected value per data_raw tests looks like it will work.

@imanuelcostigan
Copy link
Contributor Author

Similar type of problem: SQL Server does not define a DATE() function. As a result, the data_date test fails with the message:

Unable to retrieve result set for 
SELECT date('2015-01-01') as a, date('2015-02-02') as b, 
date('2015-03-03') as c, date('2015-04-04') as d, date('2015-05-05') as e, 
date('2015-06-06') as f, date('2015-07-07') as g, date('2015-08-08') as h, 
date('2015-09-09') as i, date('2015-10-10') as j, date('2015-11-11') as k, 
date('2015-12-12') as l, current_date as m: 
'date' is not a recognized built-in function name.

The equivalent in SQL Server is DATENAME() I think

@imanuelcostigan
Copy link
Contributor Author

imanuelcostigan commented Dec 24, 2016

Another one: data_time where SQL generated is SELECT time '00:00:00' as a, time '12:34:56' as b, current_time as c. This fails to parse in SQL Server. Instead something like this would be needed: SELECT CAST('00:00:00' as time(7)) as a...

Similarly, SELECT time('00:00:00') as a, time('12:34:56') as b, current_time as c: 'time' is not a recognized built-in function name.

@imanuelcostigan
Copy link
Contributor Author

Also related #77

@imanuelcostigan imanuelcostigan changed the title SQL data types Allow for different SQL dialects in test cases Dec 24, 2016
@krlmlr
Copy link
Member

krlmlr commented Jan 30, 2017

Tweaks for creating date, time and timestamp literals will be available very soon. A similar approach can be used for #77.

@krlmlr krlmlr closed this as completed in 4eb57f2 Jan 31, 2017
krlmlr added a commit that referenced this issue Jan 31, 2017
- `DBItest_tweaks` class gains a `$` method, accessing an undefined tweak now raises an error.
- The arguments of the `tweaks()` function now have default values that further describe their intended usage.
- New `with_closed_connection()`, `with_invalid_connection()`, `with_result()` and `with_remove_test_table()` helpers, and `expect_visible()`, `expect_inbisible_true()`, and `expect_equal_df()` expectations for more concise tests.
- Added prose specifications, and enhanced/modified/renamed tests for `dbConnect()`, `dbDisconnect()`, `dbDataType()`, `dbSendQuery()`, `dbFetch()`, `dbClearResult()`, `dbGetQuery()`, `dbSendStatement()`, `dbExecute()`, `dbQuoteIdentifier()`, `dbQuoteString()`, `dbReadTable()`, `dbWriteTable()`, `dbRemoveTable()`, `dbExistsTable()`, and `dbListTables()` (#88).
- Testing that a warning is given if the user forgets to call `dbDisconnect()` or `dbClearResult()` (#103).
- Added roundtrip test for time values (#14).
- Added tweaks for handling date, time, timestamp, ... (#53, #76).
- Test that `dbFetch()` on update-only query returns warning (#66).
- Numeric roundtrip accepts conversion of `NaN` to `NA` (#79).
krlmlr added a commit that referenced this issue Jun 19, 2017
Finalize specification. Most tests now come with a corresponding prose,
only those where the behavior is not finally decided don't have a prose
version yet (#88).

New tests
---------

- Test behavior of methods in presence of placeholders (#120).
- Test column name mismatch behavior for appending tables (#93).
- Test that `dbBind()` against factor works but raises a warning (#91).
- Test roundtrip of alternating empty and non-empty strings (#42).
- Test multiple columns of different types in one statement or table
(#35).
- Test `field.types` argument to `dbWriteTable()` (#12).
- Added tests for invalid or closed connection argument to all methods
that expect a connection as first argument (#117).
- Enabled test that tests a missing `dbDisconnect()`.
- Add test for unambiguous escaping of identifiers
(r-dbi/RSQLite#123).
- Reenable tests for visibility (#89).
- Fix and specify 64-bit roundtrip test.
- 64-bit integers only need to be coercible to `numeric` and `character`
(#74).
- Added roundtrip test for time values (#14).
- Added tweaks for handling date, time, timestamp, ... (#53, #76).
- Test that `dbFetch()` on update-only query returns warning (#66).

Adapted tests
-------------

- `NULL` is a valid value for the `row.names` argument, same as `FALSE`.
- A column named `row_names` receives no special handling (#54).
- A warning (not an error anymore) is expected when calling
`dbDisconnect()` on a closed or invalid connection.
- `row.names = FALSE` is now the default for methods that read or write
tables.
- Add `NA` to beginning and end of columns in table roundtrip tests
(#24).
- Stricter tests for confusion of named and unnamed SQL parameters and
placeholders (#107).
- Also check names of all returned data frames.
- The return value for all calls to `dbGetQuery()`, `dbFetch()`, and
`dbReadTable()` is now checked for consistency (all columns have the
same length, length matches number of rows) (#126).
- Removed stress tests that start a new session.
- Allow `hms` (or other subclasses of `difftime`) to be returned as time
class (#135, @jimhester).
- Test that dates are of type `numeric` (#99, @jimhester).
- Replace `POSIXlt` by `POSIXct` (#100, @jimhester).
- Use `"PST8PDT"` instead of `"PST"` as time zone (#110, @thrasibule).
- Added tests for support of `blob` objects (input and output), but
backends are not required to return `blob` objects (#98).
- The `logical_return`, `date_typed` and `timestamp_typed` tweaks are
respected by the bind tests.
- Fixed tests involving time comparison; now uses UTC timezone and
compares against a `difftime`.
- Tests for roundtrip of character values now includes tabs, in addition
to many other special characters (#85).
- Make sure at least one table exists in the `dbListTables()` test.
- Fix roundtrip tests for raw columns: now expecting `NULL` and not `NA`
entries for SQL NULL values.
- Fix `expect_equal_df()` for list columns.
- Testing that a warning is given if the user forgets to call
`dbDisconnect()` or `dbClearResult()` (#103).
- Numeric roundtrip accepts conversion of `NaN` to `NA` (#79).

Internal
--------

- Fix R CMD check errors.
- Internal consistency checks (#114).
- Skip patterns that don't match any of the tests now raise a warning
(#84).
- New `test_some()` to test individual tests (#136).
- Use desc instead of devtools (#40).
- All unexpected warnings are now reported as test failures (#113).
- `DBItest_tweaks` class gains a `$` method, accessing an undefined
tweak now raises an error.
- The arguments of the `tweaks()` function now have default values that
further describe their intended usage.
- New `with_closed_connection()`, `with_invalid_connection()`,
`with_result()` and `with_remove_test_table()` helpers, and
`expect_visible()`, `expect_inbisible_true()`, and `expect_equal_df()`
expectations for more concise tests.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants