Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source references #78

Closed
krlmlr opened this issue Jun 8, 2016 · 1 comment
Closed

Fix source references #78

krlmlr opened this issue Jun 8, 2016 · 1 comment

Comments

@krlmlr
Copy link
Member

krlmlr commented Jun 8, 2016

shown by testthat, currently showing only @run.R#17.

@krlmlr krlmlr closed this as completed in e3d02c6 Jun 24, 2016
@krlmlr
Copy link
Member Author

krlmlr commented Jun 24, 2016

@hadley: e3d02c6 works like a charm, I wonder if an improved version should be part of testthat.

krlmlr pushed a commit that referenced this issue Jun 24, 2016
- `testthat` now shows a more accurate location for the source of errors, failures, and skips (#78).
- New `constructor_relax_args` tweak, currently not queried.
- The `ctx` argument is now explicit in the test functions.
- Aggregate skipped tests, only one `skip()` call per test function.
- `tweaks()` gains an `...` as first argument to support future/deprecated tweaks (with a warning), and also to avoid unnamed arguments (#83).
- Change underscores to dashes in file names.
- Remove `testthat` compatibility hack.
krlmlr pushed a commit that referenced this issue Jul 7, 2016
Bug fixes
---------

- Fix `read_table` test when the backend actually returns the data in a different order.

New tests
---------

- Test `dbDataType()` on connections (#69, #75, @imanuelcostigan).
- Check returned strings for UTF-8 encoding (#72).
- Repeated `dbBind()` + `dbFetch()` on the same result set (#51).

Features
--------

- `tweaks()` gains an `...` as first argument to support future/deprecated tweaks (with a warning), and also to avoid unnamed arguments (#83).
- `testthat` now shows a more accurate location for the source of errors, failures, and skips (#78).
- Aggregate skipped tests, only one `skip()` call per test function.
- Indicate that some tests are optional in documentation (#15).

Internal
--------

- New `constructor_relax_args` tweak, currently not queried.
- The `ctx` argument is now explicit in the test functions.
- Change underscores to dashes in file names.
- Remove `testthat` compatibility hack.
- New `all_have_utf8_or_ascii_encoding()` which vectorizes `has_utf8_or_ascii_encoding()`.
- Test on AppVeyor (#73).
- Work around regression in R 3.3.0 (fix scheduled for R 3.3.1) which affected stress tests.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant