Skip to content

Big refactoring #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 of 7 tasks
krlmlr opened this issue Jun 20, 2016 · 1 comment
Closed
5 of 7 tasks

Big refactoring #81

krlmlr opened this issue Jun 20, 2016 · 1 comment
Assignees
@krlmlr
Milestone
1.4

Comments

@krlmlr
Copy link
Member

krlmlr commented Jun 20, 2016 •
edited
Loading

  • Explicit ctx in all tester functions
  • Move tester functions to separate modules
    • At least one module per method tested, not one module per class
    • Find a better home for utility functions
  • Prepare tests so that prose can be embedded easily
  • Support an easy way to run individual test functions
  • Sane ordering of methods (like in DBI vignette)
  • How to document/test interplay between methods?
    • Fetch results
    • Transaction
    • Parameters
    • ...
@krlmlr krlmlr added this to the 1.3 milestone Jun 20, 2016
@krlmlr krlmlr self-assigned this Jun 20, 2016
krlmlr pushed a commit that referenced this issue Jun 23, 2016
Merge branch 'master' into f-#81-big
3557369
krlmlr pushed a commit that referenced this issue Jun 24, 2016
Merge branch 'master' into f-#81-big
f2707fc
krlmlr pushed a commit that referenced this issue Jun 24, 2016
Merge branch 'master' into f-#81-big
29fc744
krlmlr pushed a commit that referenced this issue Jun 24, 2016
Merge branch 'master' into f-#81-big
24ef49a
krlmlr pushed a commit that referenced this issue Jul 7, 2016
Merge branch 'master' into f-#81-big
0432210
krlmlr pushed a commit that referenced this issue Jul 31, 2016
Merge branch 'f-#81-big'
68ab1fa 
- Refactor test specification in smaller modules, isolated from actual test execution (#81).
- Minor corrections for "bind" tests.
krlmlr pushed a commit that referenced this issue Jul 31, 2016
Merge tag 'v1.3-1'
49ee401 
- Refactor test specification in smaller modules, isolated from actual test execution (#81). This breaks the documentation of the tests, which will substituted by a DBI specification in prose.
- Minor corrections for "bind" tests.
krlmlr pushed a commit that referenced this issue Jul 31, 2016
Merge branch 'b-#81-cmd-check'
33d4ab9 
- Avoid empty subsections in Rd documentation to satisfy `R CMD check` (#81).
krlmlr pushed a commit that referenced this issue Jul 31, 2016
Merge tag 'v1.3-2'
16870ce 
- Avoid empty subsections in Rd documentation to satisfy `R CMD check` (#81).
krlmlr added a commit that referenced this issue Dec 4, 2016
@krlmlr
Merge tag 'v1.4'
66d3bfa 
- Use markdown in documentation.
- Description of parametrized queries and statements (#88).
- New hidden `DBIspec-wip` page for work-in-progress documentation.
- Get rid of "Format" and "Usage" sections, and aliases, in the specs.

- Not testing for presence of `max.connections` element in `dbGetInfo(Driver)` (r-dbi/DBI#56).
- Test multi-row binding for queries and statements (#96).
- New `ellipsis` check that verifies that all implemented DBI methods contain `...` in their formals. This excludes `show()` and all methods defined in this or other packages.
- Refactored `bind_` tests to use the new `parameter_pattern` tweak (#95).
- Rough draft of transaction tests (#36).
- New `fetch_zero_rows` test, split from `fetch_premature_close`.
- The "compliance" test tests that the backend package exports exactly one subclass of each DBI virtual class.
- Document and enhance test for `dbDataType("DBIDriver", "ANY")` (#88).
- Minor corrections for "bind" tests.

- Isolate stress tests from main test suite (#92).
- Refactor test specification in smaller modules, isolated from actual test execution (#81). This breaks the documentation of the tests, which will be substituted by a DBI specification in prose.
- Align description of binding with code.
- Refactor tests for `dbBind()`, test is run by `BindTester` class, and behavior is specified by members and by instances of the new `BindTesterExtra` class.
- The `skip` argument to the `test_()` functions is again evaluated with `perl = TRUE` to support negative lookaheads (#33).
- Use `dbSendStatement()` and `dbExecute()` where appropriate.
- Avoid empty subsections in Rd documentation to satisfy `R CMD check` (#81).
@krlmlr
Copy link
Member Author

krlmlr commented Jan 30, 2017

Closing this. There will be a more or less 1:1 mapping from DBI functions to specifications+tests.

@krlmlr krlmlr closed this as completed Jan 30, 2017
@ghost ghost removed the in progress label Jan 30, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krlmlr krlmlr

Labels
None yet
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
1 participant
@krlmlr