Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dbBind() tests #95

Closed
krlmlr opened this issue Sep 17, 2016 · 0 comments
Closed

Refactor dbBind() tests #95

krlmlr opened this issue Sep 17, 2016 · 0 comments
Assignees
@krlmlr
Milestone
1.4

Comments

@krlmlr
Copy link
Member

krlmlr commented Sep 17, 2016 •
edited
Loading

One set of tests, with tweaks.
@krlmlr krlmlr added this to the 1.4 milestone Sep 17, 2016
@krlmlr krlmlr self-assigned this Sep 17, 2016
krlmlr added a commit to r-dbi/RPostgres that referenced this issue Sep 17, 2016
@krlmlr
use new placeholder_pattern tweak for r-dbi/DBItest#95
fafbe63
krlmlr added a commit to r-dbi/RSQLite that referenced this issue Sep 17, 2016
@krlmlr
use new placeholder_pattern tweak for r-dbi/DBItest#95
4ea89a5
krlmlr added a commit to r-dbi/RMySQL that referenced this issue Sep 17, 2016
@krlmlr
use new placeholder_pattern tweak for r-dbi/DBItest#95
9767afa
@krlmlr krlmlr closed this as completed in 45451c6 Sep 17, 2016
@ghost ghost removed the in progress label Sep 17, 2016
krlmlr added a commit that referenced this issue Sep 17, 2016
@krlmlr
Merge tag 'v1.3-8'
861fc76 
- Refactored `bind_` tests to use the new `parameter_pattern` tweak (#95).
- Rough draft of transaction tests (#36).
@krlmlr krlmlr mentioned this issue Oct 1, 2016
Closed
krlmlr added a commit that referenced this issue Dec 4, 2016
@krlmlr
Merge tag 'v1.4'
66d3bfa 
- Use markdown in documentation.
- Description of parametrized queries and statements (#88).
- New hidden `DBIspec-wip` page for work-in-progress documentation.
- Get rid of "Format" and "Usage" sections, and aliases, in the specs.

- Not testing for presence of `max.connections` element in `dbGetInfo(Driver)` (r-dbi/DBI#56).
- Test multi-row binding for queries and statements (#96).
- New `ellipsis` check that verifies that all implemented DBI methods contain `...` in their formals. This excludes `show()` and all methods defined in this or other packages.
- Refactored `bind_` tests to use the new `parameter_pattern` tweak (#95).
- Rough draft of transaction tests (#36).
- New `fetch_zero_rows` test, split from `fetch_premature_close`.
- The "compliance" test tests that the backend package exports exactly one subclass of each DBI virtual class.
- Document and enhance test for `dbDataType("DBIDriver", "ANY")` (#88).
- Minor corrections for "bind" tests.

- Isolate stress tests from main test suite (#92).
- Refactor test specification in smaller modules, isolated from actual test execution (#81). This breaks the documentation of the tests, which will be substituted by a DBI specification in prose.
- Align description of binding with code.
- Refactor tests for `dbBind()`, test is run by `BindTester` class, and behavior is specified by members and by instances of the new `BindTesterExtra` class.
- The `skip` argument to the `test_()` functions is again evaluated with `perl = TRUE` to support negative lookaheads (#33).
- Use `dbSendStatement()` and `dbExecute()` where appropriate.
- Avoid empty subsections in Rd documentation to satisfy `R CMD check` (#81).
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@krlmlr krlmlr

Labels
None yet
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
1 participant
@krlmlr