Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added encoding arguments #60

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Added encoding arguments #60

merged 1 commit into from
Mar 10, 2016

Conversation

hoesler
Copy link
Contributor

@hoesler hoesler commented Mar 8, 2016

Without setting the encoding arguments explicitly, iconv uses the encoding of the current locale. This broke my windows build on AppVeyor.

krlmlr added a commit that referenced this pull request Mar 10, 2016
- Added encoding arguments to non-ASCII string constants (#60, @hoesler).
@krlmlr krlmlr merged commit 13e082c into r-dbi:master Mar 10, 2016
@krlmlr
Copy link
Member

krlmlr commented Mar 10, 2016

Thanks!

krlmlr pushed a commit that referenced this pull request Mar 10, 2016
- Compatibility with dev version of `testthat` (#62).
- Added encoding arguments to non-ASCII string constants (#60, @hoesler).
krlmlr pushed a commit that referenced this pull request May 24, 2016
- Infrastructure
    - Support names for contexts (@hoesler, #67).
    - The `skip` argument to the test functions is now treated as a Perl regular expression to allow negative lookahead. Use `skip = "(?!test_regex).*"` to choose a single test to run (#33).
    - Added encoding arguments to non-ASCII string constants (#60, @hoesler).
- Improve tests
    - `simultaneous_connections` test always closes all connections on exit (@hoesler, #68).
    - More generic compliance check (@hoesler, #61).
    - Update documentation to reflect test condition (@imanuelcostigan, #70).
- `testthat` dependency
    - Import all of `testthat` to avoid `R CMD check` warnings.
    - Compatibility with dev version of `testthat` (#62).
- Improve Travis builds
    - Use container-based builds on Travis.
    - Install `RPostgres` and `RMySQL` from `rstats-db`.
    - Install `DBI` and `testthat` from GitHub.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants