Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test data types on connections #75

Merged
merged 2 commits into from
Jun 8, 2016

Conversation

imanuelcostigan
Copy link
Contributor

See #69

@krlmlr krlmlr merged commit 5530e28 into r-dbi:master Jun 8, 2016
@krlmlr
Copy link
Member

krlmlr commented Jun 8, 2016

Thanks!

@imanuelcostigan imanuelcostigan deleted the fix-data-type-69 branch June 9, 2016 05:27
krlmlr pushed a commit that referenced this pull request Jun 20, 2016
- Test on AppVeyor (#73).
- Check returned strings for UTF-8 encoding (#72).
- Test `dbDataType()` on connections (#69, #75, @imanuelcostigan).
krlmlr pushed a commit that referenced this pull request Jul 7, 2016
Bug fixes
---------

- Fix `read_table` test when the backend actually returns the data in a different order.

New tests
---------

- Test `dbDataType()` on connections (#69, #75, @imanuelcostigan).
- Check returned strings for UTF-8 encoding (#72).
- Repeated `dbBind()` + `dbFetch()` on the same result set (#51).

Features
--------

- `tweaks()` gains an `...` as first argument to support future/deprecated tweaks (with a warning), and also to avoid unnamed arguments (#83).
- `testthat` now shows a more accurate location for the source of errors, failures, and skips (#78).
- Aggregate skipped tests, only one `skip()` call per test function.
- Indicate that some tests are optional in documentation (#15).

Internal
--------

- New `constructor_relax_args` tweak, currently not queried.
- The `ctx` argument is now explicit in the test functions.
- Change underscores to dashes in file names.
- Remove `testthat` compatibility hack.
- New `all_have_utf8_or_ascii_encoding()` which vectorizes `has_utf8_or_ascii_encoding()`.
- Test on AppVeyor (#73).
- Work around regression in R 3.3.0 (fix scheduled for R 3.3.1) which affected stress tests.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants