Dev/test - #277
Merged
Merged
Dev/test#277
Conversation
Remove `stringsAsFactors = FALSE` as suggested in r-dbi#233 (comment)
krlmlr
reviewed
Jan 7, 2019
krlmlr
left a comment
krlmlr
left a comment
Member
There was a problem hiding this comment.
Thanks! Overall this looks good, I added a few remarks.
r-dbi#277 (comment) Use `skip_on_os`
replace the variable name by its meaning r-dbi#277 (comment)
Use `skip_on_os`
Member
|
Thanks! |
Member
|
The last test doesn't seem to include any expectations? What do we test here? |
Contributor
Author
|
As I remember, they are testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #233 (comment)