Skip to content

Add extended type support to dbWriteTable#360

Merged
krlmlr merged 4 commits into
r-dbi:mainfrom
ablack3:f-dbwritedate-#351
Apr 11, 2021
Merged

Add extended type support to dbWriteTable#360
krlmlr merged 4 commits into
r-dbi:mainfrom
ablack3:f-dbwritedate-#351

Conversation

@ablack3

@ablack3 ablack3 commented Apr 2, 2021

Copy link
Copy Markdown

This PR modifies the dbDataType method to recognize date, time, and datetime types when the extended_types argument is TRUE. #351

@ablack3 ablack3 marked this pull request as draft April 2, 2021 21:05
@ablack3 ablack3 marked this pull request as ready for review April 8, 2021 17:19

@krlmlr krlmlr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Comment thread R/SQLiteDriver.R Outdated
@krlmlr krlmlr merged commit d396891 into r-dbi:main Apr 11, 2021
@krlmlr

krlmlr commented Apr 11, 2021

Copy link
Copy Markdown
Member

Thanks! Please note that this project uses roxygen2 to create .Rd files; I'll take care of tweaking it.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants