SQLite: build with SQLITE_USE_URI=1 - #390
Merged
Merged
Conversation
Member
|
Thanks! |
Contributor
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen some problems attaching to in-memory databases from RSQLite that have been created from within C code, resulting in files being created on the filesystem such as
tests/testthat/file:name?mode=memory&vfs=some-stub, due to RSQLite not understanding that these are URIs.We have managed to resolve these problems with the attached patch, which essentially enables URI support at compile-time.
It may be relevant to reviewers to note that the SQLite developers state that it is safe for most applications to enable URI processing:
CC: @jrandall