chore: Replace Rcpp by cpp11 - #441
Conversation
* Link to cpp11 * Add C++11 to SystemRequirements * Define `STRICT_R_HEADERS` and `R_NO_REMAP` * Include `cpp11` * Define `as_cpp()` for `DbResult*` and `SqliteResult*`
|
@krlmlr We can implement this logic in RSQLite just using R native functions or just remove catching of errors from R, at least for now. |
|
I remember seeing a safe modifier, e.g., in https://github.com/cran/duckdb/blob/f2550069da4019ebb5f81103dd92d471c40d4d3b/inst/include/cpp11/list.hpp#L92 Would that help? |
|
I also wonder why you commit with a different committer name and e-mail. Is this from gitpod? |
|
Yes, this is due to the |
Yes, I didn't think about |
|
Thanks, weird. Can you please try this in a clean repository that doesn't have a |
Yes, I will try |
krlmlr
left a comment
There was a problem hiding this comment.
Can we vendor the cpp11 package with cpp11::vendor_cpp11() and fix the tests that are now skipped?
|
We should un-skip the tests and fix the code instead. @Antonov548: can you please take a look? |
|
@Antonov548: The "interrupt" test still fails legitimately. To reproduce, the package needs to be installed with |
|
Thanks! |
Uh oh!
There was an error while loading. Please reload this page.