feat: New sqliteIsTransacting() that returns if a transaction is active on the current connection - #462
Merged
Merged
Conversation
krlmlr
approved these changes
Jun 7, 2023
sqliteIsTransacting() that returns if a transaction is active on the current connection
Member
|
Thanks! |
Member
|
@bpvgoncalves: 2d4ac14 introduces a problem with the orderly package, found through Other packages fail too with the current main branch. Can you please take a look? My #!/bin/sh
set -ex
git clean -fdx src
R CMD INSTALL .
R -q -e 'rcmdcheck::rcmdcheck("~/git/R/orderly")' |
Contributor
Author
|
Hello. I missed this mail last night. I'm really sorry this change broke
something... I'll take a look at it. Best regards.
…On Mon, 12 Jun 2023, 22:29 Kirill Müller, ***@***.***> wrote:
@bpvgoncalves <https://github.com/bpvgoncalves>: 2d4ac14
<2d4ac14>
introduces a problem with the orderly package, found through git bisect.
That package fails R CMD check after this commit.
Other packages fail too with the current main branch. Can you please take
a look?
My test.sh for git bisect :
#!/bin/sh
set -ex
git clean -fdx src
R CMD INSTALL .
R -q -e 'rcmdcheck::rcmdcheck("~/git/R/orderly")'
—
Reply to this email directly, view it on GitHub
<#462 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXBNOPECRKJJY5WS2XWK7DXK533RANCNFSM6AAAAAAYJQEEVI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
So... It looks orderly, and possibly other packages, are at some point applying a commit/rollback when no open transactions exists. After applying PR #464 it seem to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to issue #453 I implemented a functionality to allow checking of transaction status.
I cannot find any develop branch so the PR targets the main branch.
It passes the tests:
It CMD CHECKs in my local machine (only 1 NOTE unrelated to the changes)
Best Regards