fix: Ensure that testthat::skip() is only called in RSQLite's own tests, never in the tests for other packages

[jeanetteclark]

Fixes #515

• added setup.R to set package_name option and unset it after test are run
• removed dbConnect from list of packages to check (AFAICT it doesn't exist anymore)
• minor doc update that cropped up after running R CMD check

remaining tasks for #515

• add an & to the conditional with getOptions("package_name") == "RSQLite"
• wrap malformed message in glue

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[krlmlr]

Thanks, good start. Would you like to add the rest of the implementation to this PR?

For the next steps: Inside if (), && is always better than & .

[krlmlr]

Interesting, where does this come from?

[jeanetteclark]

I ran a CMD check after making my changes out of habit and it showed up on devtools::document(). figured I'd go ahead and commit it

[krlmlr]

Note to self: this should have happened automatically, but hasn't due to "The decor package(s) are required for this functionality": https://github.com/r-dbi/RSQLite/actions/runs/9949313875/job/27485358644#step:11:75 .

[jeanetteclark]

Would you like to add the rest of the implementation to this PR?

As discussed in #515, the rest of the changes have to go into dm. You mentioned that you would make the changes over there but I can also make the PR if you prefer, I think its just one line change. Let me know

[krlmlr]

Thanks. Happy to review everything we want to do here as a single PR here, I can easily move to dm then.

[krlmlr]

Note to self: this should have happened automatically, but hasn't due to "The decor package(s) are required for this functionality": https://github.com/r-dbi/RSQLite/actions/runs/9949313875/job/27485358644#step:11:75 .

[krlmlr]

Thanks! Can you please also update the header of the standalone file to include the changes and the new dependency?

[jeanetteclark]

not sure why that test is failing, seems unrelated? here's the relevant log output:

  ── Failure ('test-dbConnect.R:231:3'): busy_handler timeout ────────────────────
  time < as.difftime(1, units = "secs") is not TRUE
  
  `actual`:   FALSE
  `expected`: TRUE 

[krlmlr]

Thanks for the updates and for your patience. Should we do one more round?

There's a "Changelog" section in the header that could use a bullet.

This particular test is flaky, I need to review it at some point.

[krlmlr]

This is nice, but would have to be methods::getPackageName() (why is this not flagged?), and that function does too much too.

Essentially, methods::getPackageName() calls environmentName(topenv()), that looks better to me than my initial proposal.

[jeanetteclark]

No worries. I'll work that in at some point today.

One thing to note - I removed the hms package and ran the tests locally, but a bunch failed. I'm not sure how far this particular bit of code is supposed to go in terms of skipping tests, but all the failures were from DBItest.

[krlmlr]

Thanks for pushing through!

I don't understand why removing hms fails the tests because this package is really only used with specific dbConnect() arguments, AFAICT. And there's a successful run on CI/CD without hms: https://github.com/r-dbi/RSQLite/actions/runs/9979145876/job/27577869756 .