Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmin() and pmax() translation to SQL #179

Closed
jarodmeng opened this issue Aug 5, 2017 · 0 comments

Comments

@jarodmeng
Copy link
Contributor

commented Aug 5, 2017

Currently pmax() and pmin() are translated to MIN() and MAX() respectively, via dbplyr::base_scalar.

  pmin = sql_prefix("min"),
  pmax = sql_prefix("max"),

This is problematic for BigQuery because MAX() and MIN() only accepts a single expression as argument.

A better translation is GREATEST() and LEAST() that accepts multiple expressions as arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.