Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 #45

Closed
hadley opened this issue Jan 9, 2015 · 2 comments

Comments

@hadley
Copy link
Member

commented Jan 9, 2015

Should check that on windows (which doesn't use UTF-8) standardise_csv() converts to UTF-8 on write, and maintains UTF-8 encoding status on read

@krlmlr

This comment has been minimized.

Copy link
Member

commented Feb 9, 2016

I guess a more robust approach would be to use JSON for uploading instead of CSV. jsonlite seems to work fine with UTF-8 on Windows (jeroen/jsonlite#42). Another advantage: I've run into problems with corner cases such as a one-row one-column data frame with an empty value, this probably won't be an issue when JSON is used.

@hadley

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2017

And now worth considering if we should use DML: https://cloud.google.com/bigquery/docs/reference/standard-sql/data-manipulation-language (but probably slower than json)

@hadley hadley added the feature label Apr 18, 2017

@hadley hadley closed this in 8b7dca7 Apr 19, 2017

Zsedo pushed a commit to Zsedo/bigrquery that referenced this issue Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.