Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for sending the useLegacySql parameter in REST calls. #124

Merged
merged 2 commits into from Jul 21, 2016

Conversation

@backlin
Copy link
Contributor

commented Jul 1, 2016

As mentioned in issue #117, Google recently added support for executing queries written in standard SQL (in addition to legacy SQL). To use it in BigRQuery I just added an argument useLegacySql to a few functions and included the value in the REST call.

Thanks for a great package and hope you find this update useful!

Christofer Backlin Christofer Backlin
DESCRIPTION Outdated
@@ -1,7 +1,7 @@
Package: bigrquery
Title: An Interface to Google's 'BigQuery' 'API'
Description: Easily talk to Google's 'BigQuery' database from R.
Version: 0.3.0.9000
Version: 0.3.1.9000

This comment has been minimized.

Copy link
@craigcitro

craigcitro Jul 16, 2016

Collaborator

spurious?

This comment has been minimized.

Copy link
@backlin

backlin Jul 19, 2016

Author Contributor

I wasn't sure how to deal with the version number, so feel free to change it to whatever you prefer. Because I had added functionality I though it was appropriate to at least increase the patch number.

This comment has been minimized.

Copy link
@craigcitro

craigcitro Jul 19, 2016

Collaborator

In general the version number only gets changed around releases; for Hadley's packages, to make development a little easier, he adds a .9000 between last release and the next one.

Can you just revert this one hunk and we're good to go?

@craigcitro

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2016

This looks good, modulo one little nit.

I suspect we're ultimately going to want a global setting for this, too, but this is a great start.

(And sorry about the slow review!)

@craigcitro craigcitro merged commit 9c539c7 into r-dbi:master Jul 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@craigcitro

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2016

Thanks!

@backlin backlin deleted the backlin:feature/useLegacySqlOption branch Jul 22, 2016

hadley added a commit that referenced this pull request Apr 18, 2017

Rename useLegacySql to use_legacy_sql
And add news bullet. #124

Zsedo pushed a commit to Zsedo/bigrquery that referenced this pull request Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.