Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no output #206

Merged
merged 11 commits into from Mar 29, 2018

Conversation

@byapparov
Copy link
Contributor

commented Mar 5, 2018

Fixes #171 - error that happens for queries that return zero rows.

byapparov added some commits Sep 16, 2017

Merge pull request #1 from r-dbi/master
Fix %||% function's SQL translation (#178)

@byapparov byapparov closed this Mar 6, 2018

@byapparov byapparov deleted the byapparov:fix-no-output branch Mar 6, 2018

@hadley

This comment has been minimized.

Copy link
Member

commented Mar 28, 2018

@byapparov is there a reason you closed this PR? It looks good.

@byapparov byapparov restored the byapparov:fix-no-output branch Mar 29, 2018

@byapparov byapparov reopened this Mar 29, 2018

@byapparov

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2018

@hadley good question. I was doing clean-up on my fork and closed it by mistake.

Thanks!

@hadley

This comment has been minimized.

Copy link
Member

commented Mar 29, 2018

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

Can you please also include Fixes #xyz in a commit message (or the text of the PR), then the corresponding issue will be automatically closed when the PR is merged.

@byapparov byapparov changed the title Fix no output Fix no output fixes #171 Mar 29, 2018

byapparov added some commits Mar 29, 2018

@byapparov byapparov changed the title Fix no output fixes #171 Fix no output Mar 29, 2018

@byapparov

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2018

@hadley updated PR body and news.

@hadley hadley merged commit c76471d into r-dbi:master Mar 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@byapparov byapparov deleted the byapparov:fix-no-output branch Apr 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.