Align Google APIs URLs with Discovery docs per #541

[husseyd]

Align Google APIs URLs with Discovery docs per #541

• Align Google APIs URLs to Google Cloud Discovery docs. This enables support for Private and Restricted Google APIs configurations.

  • R/bq-request.R
    • Substitute https://bigquery.googleapis.com for https://www.googleapis.com
  • R/gs-object.R
    • Substitute https://storage.googleapis.com for https://www.googleapis.com
  • No updates to OAuth scope URLs
    • (E.G. https://www.googleapis.com/auth...). These do not require change.

• Update NEWS.md and bump version to 1.4.3

[craigcitro]

Thanks for sending the PR! I think there are a few more references in the code; IMO probably worth changing all of them? https://github.com/search?q=repo%3Ar-dbi%2Fbigrquery%20www.googleapis.com&type=code

otherwise LGTM, though @hadley or @jennybc should really be the one to approve/merge.

[husseyd]

Hi @hadley, @craigcitro,

MR created for #541, all tests passing. I am unsure how you'd like to handle release but have bumped the version number in NEWS.md - please let me know if I should remove this so you can handle that part yourselves.

[husseyd]

Thanks for sending the PR! I think there are a few more references in the code; IMO probably worth changing all of them? https://github.com/search?q=repo%3Ar-dbi%2Fbigrquery%20www.googleapis.com&type=code

otherwise LGTM, though @hadley or @jennybc should really be the one to approve/merge.

@craigcitro I looked into this - those /auth URLs are not actually called, they are included as scopes for OAuth token generation. All the GCP docs I can find still use scopes in the https://www.googleapis.com/auth... format, so I don't think these should be changed.

Updated PR to reflect this.

[craigcitro]

ah great catch -- you're totally right, the scopes shouldn't change. LGTM!

[hadley]

Please remove this heading; we add during the release process.

[husseyd]

Done thanks @hadley

[hadley]

Can you please add the issue number and your name? See details at https://style.tidyverse.org/news.html#acknowledgement.

[husseyd]

Done thanks @hadley

[hadley]

Thanks!

[husseyd]

Thanks @hadley @craigcitro!
So I can provide back to my team, what kind of timeline is there for publishing this to CRAN?

[hadley]

We don't have a release currently scheduled.