Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert_upload_job() gains create_disposition and write_disposition args #92

Merged
merged 4 commits into from Feb 8, 2016

Conversation

@krlmlr
Copy link
Member

commented Feb 7, 2016

analogously to copy_table(), except for the default value for write_disposition which is "WRITE_APPEND" instead of "WRITE_EMPTY".

Closes #33.

Kirill Müller added some commits Feb 7, 2016

Kirill Müller
insert_upload_job() gains create_disposition and write_disposition args
analogously to copy_table(), except for the default value for `write_disposition` which is `"WRITE_APPEND"` instead of `"WRITE_EMPTY"`.
Kirill Müller
Kirill Müller
@craigcitro

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2016

LGTM

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2016

Merged master to avoid merge conflict in NEWS. (FWIW, pull requests are O(n²) if each updates the NEWS file...)

@krlmlr

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2016

Duplicate of #33, I've added a "Closes ..." to the description.

craigcitro added a commit that referenced this pull request Feb 8, 2016

Merge pull request #92 from krlmlr/feature/upload-disposition
insert_upload_job() gains create_disposition and write_disposition args

@craigcitro craigcitro merged commit ee9d4e7 into r-dbi:master Feb 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.